add caching copy layers back #1518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tejal29
force-pushed
the
add_copy_cache_back
branch
4 times, most recently
from
c4fff02 to
6066c03
Compare
|
Manual testing notes without the flag |
tejal29
force-pushed
the
add_copy_cache_back
branch
from
6066c03 to
e678705
Compare
|
Hey @tejal29 thank you for adding this back. Do you know when this will be released? |
|
waiting for the feature too. |
gilbsgilbs
added a commit
to gilbsgilbs/kaniko
that referenced
this pull request
Sep 9, 2021
…Tools#1706) PR GoogleContainerTools#1518 reintroduced COPY layers caching using the `--cache-copy-layers` flag. Unfortunately, this PR also introduced a bug by not including the stage digest into the caching key of the COPY command when the `--cache-copy-layers` flag was not set. As a result, kaniko would use any previous (possibly stalled) layer from the cache because the digest of the "COPY --from" command would never change. PR author probably expected Go to fallthrough in the switch just like C does. However, this is not the case. Go does not fallthrough in switch-statements by default and requires the fallthrough keyword to be used. Note that this keyword is not available in type-switches though, because it wouldn't work properly with typings.
gilbsgilbs
added a commit
to gilbsgilbs/kaniko
that referenced
this pull request
Sep 9, 2021
…Tools#1706) PR GoogleContainerTools#1518 reintroduced COPY layers caching using the `--cache-copy-layers` flag. Unfortunately, this PR also introduced a bug by not including the stage digest into the caching key of the COPY command when the `--cache-copy-layers` flag was not set. As a result, kaniko would use any previous (possibly stalled) layer from the cache because the digest of the "COPY --from" command would never change. PR author probably expected Go to fallthrough in the switch just like C does. However, this is not the case. Go does not fallthrough in switch-statements by default and requires the fallthrough keyword to be used. Note that this keyword is not available in type-switches though, because it wouldn't work properly with typings.
tejal29
pushed a commit
to gilbsgilbs/kaniko
that referenced
this pull request
Oct 19, 2021
…Tools#1706) PR GoogleContainerTools#1518 reintroduced COPY layers caching using the `--cache-copy-layers` flag. Unfortunately, this PR also introduced a bug by not including the stage digest into the caching key of the COPY command when the `--cache-copy-layers` flag was not set. As a result, kaniko would use any previous (possibly stalled) layer from the cache because the digest of the "COPY --from" command would never change. PR author probably expected Go to fallthrough in the switch just like C does. However, this is not the case. Go does not fallthrough in switch-statements by default and requires the fallthrough keyword to be used. Note that this keyword is not available in type-switches though, because it wouldn't work properly with typings.
tejal29
added a commit
that referenced
this pull request
Oct 19, 2021
* chore: add workflows for pr tests * fix unit tests * fix formatting * chore: fix gobuild * change minikube script * chore: fix lint install script * chore: ignore and fix tests * fix lint and run gofmt * lint fixes * k8s executor image only * fix Makefile * fix travis env variables * more info on k8s tests * fix travis run * fix * fix * fix * fix log * some more changes * increase timeout * delete travis.yml and fix multiple copy tests * fix registry mirror * fix lint * add concurency * last attemot to fix k8 integrations * diff id for diff workflows * Fix composite cache key for multi-stage copy command (#1706) PR #1518 reintroduced COPY layers caching using the `--cache-copy-layers` flag. Unfortunately, this PR also introduced a bug by not including the stage digest into the caching key of the COPY command when the `--cache-copy-layers` flag was not set. As a result, kaniko would use any previous (possibly stalled) layer from the cache because the digest of the "COPY --from" command would never change. PR author probably expected Go to fallthrough in the switch just like C does. However, this is not the case. Go does not fallthrough in switch-statements by default and requires the fallthrough keyword to be used. Note that this keyword is not available in type-switches though, because it wouldn't work properly with typings. * refactor: add an abstract copy command interface to avoid code duplication * fix typo in error message Co-authored-by: Tejal Desai <tejal29@gmail.com>
This was referenced Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1489
Revert changes from #1408
Introduce a new flag
--cache-copy-layers